 |
Regarding the warning, the code in question is:
function loadConfigDefaults()
{
$ret = loadConfigCache();
if (!count ($ret))
throw new RackTablesError ('Failed to load configuration from the database.', RackTablesError::INTERNAL);
foreach ($ret as $varname => &$row)
{
$row['is_altered'] = 'no';
if ($row['vartype'] == 'uint')
$row['varvalue'] = 0 + $row['varvalue'];
This used to cast the value to an integer. Regarding PHP 7.1, on Ubuntu 17.04 it is available as an option (7.0 is the default). |
|
|
I have tried Ubuntu 17.04 in a virtual machine and it does not have a PHP 7.1 option despite what Ubuntu web-site implies. To fix this bug there should be a way to reproduce it first. |
 |
https://launchpad.net/~ondrej/+archive/ubuntu/php/+index?batch=75&memo=225&start=225 sudo apt-get install -y python-software-properties sudo add-apt-repository -y ppa:ondrej/php sudo apt-get update -y apt-cache pkgnames | grep php7.1 |
|
|
Thank you, let me try once again later. |
|
|
I could reproduce this issue using Fedora 26, which comes with PHP 7.1 by default. There is no quick and simple solution to this particular problem, it requires some careful re-engineering. |
|
|
From now on this issue is also visible in the Travis CI build of RackTables, which now includes a job with PHP 7.1 (which currently fails). |
|
|
The master branch now has the PHP warning in that particular function resolved and Travis CI job for PHP 7.1 currently passes. But I have found that it is not a complete solution to the problem, there is at least one more place in the code that requires a fix so this bug remains open. |
|
|
After some testing I had found that the remaining test failures on Fedora 26 were due to MariaDB, not PHP 7.1 (those are now fixed as well). Hence I consider this bug resolved, RackTables 0.21.0 will support PHP 7.1. Thank you for the report and feedback! |
- Anonymous
