View Issue Details

IDProjectCategoryView StatusLast Update
897RackTablesdefaultpublic2013-06-24 12:31
Reporterblaza-pl Assigned To 
PrioritylowSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Version0.20.4 
Target Version0.20.5Fixed in Version0.20.5 
Summary897: Bad tab order on Rackspace -> Manage rows tab
DescriptionThis fixes the tab order on Manage Rows tab.
TagsNo tags attached.

Activities

blaza-pl

blaza-pl

2013-06-18 13:32

reporter  

rowedit-taborder_interface.php.patch (1,203 bytes)   
--- inc/interface.php	2013-06-12 12:34:27.565135511 +0200
+++ /inc/interface.php	2013-06-17 07:40:16.341132554 +0200
@@ -580,8 +580,10 @@
 	echo "<tr><th>&nbsp;</th><th>Location</th><th>Name</th><th>&nbsp;</th></tr>\n";
 	if (getConfigVar ('ADDNEW_AT_TOP') == 'yes')
 		printNewItemTR();
+	$t = 103;
 	foreach (getAllRows() as $row_id => $rowInfo)
 	{
+		$t++;
 		echo "<tr><td>";
 		if ($rc = count (listCells ('rack', $row_id)))
 			printImageHREF ('nodestroy', "${rc} rack(s) here");
@@ -597,10 +599,11 @@
 		$selectlist['other'][0] = '-- NONE --';
 		foreach ($locationlist as $location_id => $locationdata)
 			$selectlist['other'][$location_id] = $locationdata['name'];
-		echo "<select name=location_id tabindex=100>";
+		echo "<select name=location_id tabindex={$t}>";
 		locationSelectTree($rowInfo['location_id']);
-		echo "</td><td><input type=text name=name value='${rowInfo['name']}'></td><td>";
-		printImageHREF ('save', 'Save changes', TRUE);
+		$t++;
+		echo "</td><td><input type=text name=name value='${rowInfo['name']}' tabindex={$t}></td><td>";
+		printImageHREF ('save', 'Save changes', TRUE,$t+1);
 		echo "</form></td></tr>\n";
 	}
 	if (getConfigVar ('ADDNEW_AT_TOP') != 'yes')

Issue History

Date Modified Username Field Change
2013-06-18 13:32 blaza-pl New Issue
2013-06-18 13:32 blaza-pl File Added: rowedit-taborder_interface.php.patch
2013-06-23 19:37 andriyanov Status new => closed
2013-06-23 19:37 andriyanov Resolution open => fixed
2013-06-23 19:37 andriyanov Product Version 0.20.4 => 0.20.5
2013-06-24 12:31 infrastation Product Version 0.20.5 => 0.20.4
2013-06-24 12:31 infrastation Fixed in Version => 0.20.5
2013-06-24 12:31 infrastation Target Version => 0.20.5