Changesets: RackTables

master db8d58a6

2017-07-18 10:41:58

infrastation

Details Diff
make more unsigned integer check fixups

* isUnsignedInteger(): a new helper function that better matches the
problem space than isInteger(), with tests
* assertUIntArg(): simplify by using the above
* setConfigVar(): the function would mistakenly accept float values for
"uint" configuration variables, fix the check
* setUserConfigVar(): idem
Attach Issues:
mod - wwwroot/inc/database.php Diff File
mod - tests/PureFunctionTest.php Diff File
mod - wwwroot/inc/functions.php Diff File

master 06d7052a

2017-07-17 16:00:21

infrastation

Details Diff
assertUIntArg(): fix type check (see prev. commit)
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master 0f5c5980

2017-07-17 15:52:01

infrastation

Details Diff
fix isInteger() and add some tests

is_numeric() can test numeric strings but it accepts floats as well
because that's the way it is defined to work; is_int() tests for an
integer. Combine those two to make isInteger() really do what it claims.
Attach Issues:
mod - tests/PureFunctionTest.php Diff File
mod - wwwroot/inc/functions.php Diff File

master 3b4c0948

2017-07-17 10:41:27

infrastation

Details Diff
detect and handle an internal error properly

In fetchAttrsForObjects() throw an exception on an unknown attribute
type as that situation cannot have a reasonable default workaround.
Attach Issues:
mod - wwwroot/inc/database.php Diff File

master 1cfcac1b

2017-07-14 16:01:02

infrastation

Details Diff
only use the PHP opening tag once per file

There used to be a few code blocks that switched PHP interpreting on and
off with PHP tags, convert those to use either heredoc or plain echo as
that is the usual syntax for this purpose elsewhere in the code. Fixup
some indentation while at it.

* renderInstallerHTML()
* renderInterfaceHTML()
* renderIndex()
* dragon()
* renderSNMPPortFinder()
* renderPopupHTML()
* printStatic404()
* renderUpgraderHTML()
Attach Issues:
mod - wwwroot/inc/solutions.php Diff File
mod - wwwroot/inc/install.php Diff File
add - wwwroot/inc/secret.php.off Diff File
mod - wwwroot/inc/interface.php Diff File
mod - wwwroot/inc/upgrade.php Diff File
mod - wwwroot/inc/popup.php Diff File

master 2864fb8d

2017-07-13 18:08:35

infrastation

Details Diff
RTSNMPDevice: handle SNMP versions stricter

There is no gain in assuming that if SNMP version is not 1, not 2 and
not 3, it means it is 1. Keep it simple.
Attach Issues:
mod - wwwroot/inc/snmp.php Diff File

master f5b9c21a

2017-07-13 17:45:48

infrastation

Details Diff
renderEditObjectForm(): add a LABEL for a CHECKBOX
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master f48482e4

2017-07-13 17:09:25

infrastation

Details Diff
omit the PHP closing tag at EOF in all PHP files

"If a file is pure PHP code, it is preferable to omit the PHP closing tag
at the end of the file. This prevents accidental whitespace or new lines
being added after the PHP closing tag, which may cause unwanted effects
because PHP will start output buffering when there is no intention from
the programmer to send any output at that point in the script."
-- PHP manual
Attach Issues:
mod - tests/RackspaceFunctionsTest.php Diff File
mod - tests/ObjectPortsTest.php Diff File
mod - wwwroot/inc/dictionary.php Diff File
mod - tests/ObjectCircularReferenceTest.php Diff File
mod - tests/EntityLinkTriggerTest.php Diff File
mod - wwwroot/inc/functions.php Diff File
mod - scripts/syncdomain.php Diff File
mod - wwwroot/inc/auth.php Diff File
mod - wwwroot/inc/exceptions.php Diff File
mod - wwwroot/inc/ajax-interface.php Diff File
mod - wwwroot/inc/solutions.php Diff File
mod - wwwroot/inc/code.php Diff File
mod - wwwroot/inc/upgrade.php Diff File
mod - tests/ConfigVarTest.php Diff File
mod - wwwroot/inc/caching.php Diff File
mod - wwwroot/inc/interface-cables.php Diff File
mod - wwwroot/inc/interface-8021q.php Diff File
mod - wwwroot/inc/ophandlers.php Diff File
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/navigation.php Diff File
mod - wwwroot/inc/deviceconfig.php Diff File
mod - tests/UpgradeTest.php Diff File
mod - tests/PureFunctionTest.php Diff File
mod - wwwroot/inc/config.php Diff File
mod - wwwroot/inc/triggers.php Diff File
mod - tests/ObjectLogTest.php Diff File
mod - tests/ObjectAttributesTest.php Diff File
mod - wwwroot/inc/interface-lib.php Diff File
mod - tests/bootstrap.php Diff File
mod - wwwroot/inc/init.php Diff File
mod - tests/ScriptFunctionsTest.php Diff File
mod - tests/TagFunctionsTest.php Diff File
mod - wwwroot/index.php Diff File
mod - tests/RenderDepotTest.php Diff File
mod - tests/DBMutexTest.php Diff File
mod - wwwroot/inc/interface-config.php Diff File
mod - wwwroot/inc/remote.php Diff File
mod - wwwroot/inc/pre-init.php Diff File
mod - tests/EmptySQLWhereTest.php Diff File
mod - wwwroot/inc/popup.php Diff File
mod - tests/UserAccountTest.php Diff File
mod - wwwroot/inc/snmp.php Diff File
mod - tests/DictionaryAttributeTest.php Diff File
mod - tests/GetRowsCountTest.php Diff File
mod - tests/LinkTriggerTest.php Diff File
mod - wwwroot/inc/slb-interface.php Diff File
mod - wwwroot/inc/install.php Diff File
mod - wwwroot/inc/slb.php Diff File
mod - scripts/cleanup_ldap_cache.php Diff File
mod - tests/TestHelper.php Diff File
mod - wwwroot/inc/interface-reports.php Diff File
mod - tests/TagTreeCircularReferenceTest.php Diff File
mod - wwwroot/inc/interface.php Diff File
mod - tests/StringInsertHrefsTest.php Diff File
mod - tests/GetChildrenListTest.php Diff File

master 475f4da1

2017-07-13 17:06:27

infrastation

Details Diff
init_config(): omit the PHP closing tag at EOF
Attach Issues:
mod - wwwroot/inc/install.php Diff File

master c7be1b90

2017-07-13 17:02:28

infrastation

Details Diff
tests: test cleanup_ldap_cache.php in express.sh
Attach Issues:
mod - tests/express.sh Diff File

master b823aef0

2017-07-10 16:22:59

andriyanov

Details Diff
filter8021QChangeRequests: restrict alien vlans on uplink
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master d4efef55

2017-07-10 10:37:35

infrastation

Details Diff
add a comment as a follow-up to commit dfc8176e
Attach Issues:
mod - wwwroot/inc/exceptions.php Diff File

master 01cbc424

2017-07-07 23:25:34

infrastation

Details Diff
use BLOB to store rack thumbnail images

The contents of RackThumbnail.thumb_data used to be Base64-encoded but
the column itself does not require it as it is a BLOB so dismiss the
encoding and just store and read the image as it is. Delete all rows
from RackThumbnail.

* loadThumbCache(): rename to loadRackThumbCache()
* saveRackThumbCache(): new helper function for consistency
* dispatchMiniRackThumbRequest(): update to use the above
Attach Issues:
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/solutions.php Diff File
mod - wwwroot/inc/upgrade.php Diff File

master df611f34

2017-07-07 23:05:53

infrastation

Details Diff
HTTPDateToUnixTime(): fixup some code style
Attach Issues:
mod - wwwroot/inc/caching.php Diff File

master d2ae1e0d

2017-07-07 15:06:45

infrastation

Details Diff
check argument type in array_fetch()

If the argument is not an array, it is a bug in the code as arguments to
that function come from other functions, not directly from user input.
Raise an exception before the broken code makes any [more] damage. Add
more tests.
Attach Issues:
mod - tests/PureFunctionTest.php Diff File
mod - wwwroot/inc/functions.php Diff File

master 37095aac

2017-07-07 14:58:16

infrastation

Details Diff
put usort_portlist() right (GH #199)

The input to sortPortList() is an array of arrays, if it is an array of
anything else the function (since commit 07d22ce) will use array_fetch()
on the elements anyway, causing issues downstream. Vladimir Sukhonosov
had reported numerous PHP warnings in this regard.

Fix usort_portlist() to feed proper argument into sortPortList().
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master 3f047ada

2017-07-07 11:43:31

infrastation

Details Diff
refine a couple error messages

* proxyCactiRequest()
* proxyMuninRequest()
Attach Issues:
mod - wwwroot/inc/solutions.php Diff File

master a688bfd7

2017-07-07 11:11:41

infrastation

Details Diff
update some old comments
Attach Issues:
mod - wwwroot/inc/exceptions.php Diff File
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/ophandlers.php Diff File

master 34f5d4eb

2017-07-07 10:43:39

infrastation

Details Diff
refine some table formatting

* renderRackspaceRowEditor()
* renderRackSortForm()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master c910f77b

2017-07-07 10:06:53

infrastation

Details Diff
simplify rackModificationPermitted()

Don't do the work permitted() already does internally and clarify control
flow. This eliminates two variables.
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master 655da698

2017-07-06 17:39:18

infrastation

Details Diff
refine some code in markBestSpan()

Remove an unused global, declare arrays before the first use, use foreach
instead of hard-coded index range, spell comparison with zero, eliminate
a redundant variable and use array_search().
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master 02385005

2017-07-06 09:46:00

infrastation

Details Diff
printRackThumbImage(): clarify a comment
Attach Issues:
mod - wwwroot/inc/solutions.php Diff File

master 3c013971

2017-07-05 15:04:12

Maxime Guyot


Committer: infrastation Details Diff
Add 2028TP-HC0R-SIOM and 6028R-E1CR12L from SuperMicro
Attach Issues:
mod - wwwroot/inc/dictionary.php Diff File

master 1c48fd70

2017-07-02 15:48:02

infrastation

Details Diff
upgrade CodeMirror from 5.26.0 to 5.27.4
Attach Issues:
mod - wwwroot/js/codemirror/codemirror.js Diff File
mod - wwwroot/css/codemirror/codemirror.css Diff File

master f686aa8e

2017-06-29 20:22:14

bpothier


Committer: infrastation Details Diff
Added link to SDK in error

Added link to SDK project page in error message when python package is not installed.
Attach Issues:
mod - gateways/ucssdk Diff File
 First  Prev  1 2 3 ... 16 17 18 19 20 21 22 ... 40 ... 60 ... 80 ... 100 ... 120 ... 140 ... 160 ... 180 ... 200 ... 218 219 220  Next  Last