View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
1773 | RackTables | IPv4/IPv6/SLB | public | 2017-06-16 00:59 | 2017-06-16 16:45 |
Reporter | fstuck | Assigned To | infrastation | ||
Priority | normal | Severity | feature | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 0.20.11 | ||||
Target Version | 0.20.14 | Fixed in Version | 0.20.14 | ||
Summary | 1773: Functionality to search for IPv4 Blocks by comment (Patch enclosed) | ||||
Description | RackTables search allows searching by a comment in many types of resources, but not IPv4 Blocks. Here's a patch to resolve that! | ||||
Steps To Reproduce | * Search for something in an IPv4's comment field. Results: n/a! * Apply patch * Search for something in an IPv4's comment field. Results: works! Testing: needed? | ||||
Additional Information | This was modeled after the getObjectAttrsSearchResults function This doesn't return the comment field as part of the search results; I think this is actually OK, as comment fields can be *huge.* In the database.php file Original Search by IPv4 only searches name: function getIPv4PrefixSearchResult ($terms) { $byname = getSearchResultByField ( 'IPv4Network', array ('id'), 'name', $terms, 'ip' ); $ret = array(); foreach ($byname as $row) $ret[$row['id']] = spotEntity ('ipv4net', $row['id']); return $ret; } New Search by IPv4 searches name and comment: function getIPv4PrefixSearchResult ($terms) { $ret = array(); foreach (array ('name', 'comment') as $column) { $tmp = getSearchResultByField ( 'IPv4Network', array ('id'), $column, $terms, 'ip' ); foreach ($tmp as $row) { $ret[$row['id']] = spotEntity ('ipv4net', $row['id']); } } return $ret; } | ||||
Tags | No tags attached. | ||||
Date Modified | Username | Field | Change |
---|---|---|---|
2017-06-16 00:59 | fstuck | New Issue | |
2017-06-16 00:59 | fstuck | Status | new => assigned |
2017-06-16 00:59 | fstuck | Assigned To | => andriyanov |
2017-06-16 16:45 | infrastation | Assigned To | andriyanov => infrastation |
2017-06-16 16:45 | infrastation | Status | assigned => closed |
2017-06-16 16:45 | infrastation | Resolution | open => fixed |
2017-06-16 16:45 | infrastation | Fixed in Version | => 0.20.14 |
2017-06-16 16:45 | infrastation | Target Version | => 0.20.14 |
2017-06-16 16:45 | infrastation | Note Added: 0003635 |