Changesets: RackTables

master 174084cb

2017-07-30 11:11:27

infrastation

Details Diff
refine the new plugins code a bit

* getPlugins(): don't use "SELECT *"
* getPlugin(): idem
* formatPluginState(): use array_fetch()
* renderPluginConfig(): use renderTableViewer()
* renderPluginEditor(): idem and use "&&"
* installPlugin(): use the assertion result instead of a global
* uninstallPlugin(): idem
* upgradePlugin(): idem

Remove the PHP closing tag from the new PHP files.
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - plugins/munin/plugin.php Diff File
mod - wwwroot/inc/ophandlers.php Diff File
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/interface-config.php Diff File
mod - plugins/cacti/plugin.php Diff File

master 011df355

2017-07-29 22:34:07

adoom42

Details Diff
refactor plugin architecture

move cacti and munin code into plugins
Attach Issues:
mod - wwwroot/inc/navigation.php Diff File
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/interface.php Diff File
add - plugins/munin/plugin.php Diff File
mod - wwwroot/inc/interface-config.php Diff File
mod - wwwroot/inc/init.php Diff File
mod - wwwroot/inc/solutions.php Diff File
mod - wwwroot/inc/upgrade.php Diff File
mod - wwwroot/inc/dictionary.php Diff File
mod - wwwroot/inc/install.php Diff File
mod - ChangeLog Diff File
add - wwwroot/pix/tango-go-up.png Diff File
mod - wwwroot/inc/interface-reports.php Diff File
add - plugins/cacti/plugin.php Diff File
mod - plugins/README Diff File
mod - wwwroot/inc/ophandlers.php Diff File
mod - README.md Diff File
mod - wwwroot/inc/triggers.php Diff File
mod - .gitignore Diff File
mod - wwwroot/inc/interface-lib.php Diff File

master d0d43dcd

2017-07-27 16:25:37

infrastation

Details Diff
improve travis_setup_mysql.sh

With this change the script does not require the RackTables top
directory to be the current working directory anymore. Also it runs the
last query as root to avoid the password warning -- the next stages will
find it out anyway whether MySQL credentials work as expected.
Attach Issues:
mod - tests/travis_setup_mysql.sh Diff File

master 66eece6d

2017-07-25 13:09:50

infrastation

Details Diff
renderDataIntegrityReport(): simplify some code

Switch some tables from hard-coded HTML to renderTableViewer().
Attach Issues:
mod - wwwroot/inc/interface-reports.php Diff File

master bba495fc

2017-07-25 13:07:27

infrastation

Details Diff
use a CSS class for L2 addresses

* pi.css
* renderDataIntegrityReport()
* renderObjectPortRow()
Attach Issues:
mod - wwwroot/inc/interface-reports.php Diff File
mod - wwwroot/css/pi.css Diff File
mod - wwwroot/inc/interface.php Diff File

master c2a49f7b

2017-07-24 13:22:04

infrastation

Details Diff
update install notes based on some Fedora 26 tests
Attach Issues:
mod - README.md Diff File

master 8dd68eea

2017-07-24 09:57:56

infrastation

Details Diff
remove an old backup file
Attach Issues:
rm - wwwroot/inc/secret.php.off Diff File

master 97d8533e

2017-07-24 09:08:58

Jeroen Vermeulen


Committer: infrastation Details Diff
Improved hooks: passing binary IP address + always same argument count
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master ffccae62

2017-07-23 21:58:24

infrastation

Details Diff
dictionary: add assorted products (Mantis 1779)
Attach Issues:
mod - wwwroot/inc/dictionary.php Diff File

master 5731b2cb

2017-07-21 23:30:41

Jeroen Vermeulen


Committer: infrastation Details Diff
Added extra hooks to renderIPv4NetworkAddresses and renderIPv6NetworkAddresses
to allow plugin devs to extend/change the functionality of the IP list.
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 1d44a1e1

2017-07-21 11:27:24

infrastation

Details Diff
fixup some PHP lettercase

* string_insert_hrefs()
* email_regex_simple()
* getOptionTree()
* setEntityColors()
* renderRackSortForm()
* printRackThumbImage()
Attach Issues:
mod - wwwroot/inc/interface-lib.php Diff File
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/interface.php Diff File
mod - wwwroot/inc/solutions.php Diff File

master cf940ca6

2017-07-20 16:07:31

Miouge1


Committer: infrastation Details Diff
Add all SuperMicro chassis and servers (#201)
Attach Issues:
mod - wwwroot/inc/dictionary.php Diff File

master 1c117bdc

2017-07-20 14:39:56

Jeroen Vermeulen


Committer: infrastation Details Diff
Added extra hooks to commitUpdateObject() (#204)

...to give plugin devs more options to interact.
Attach Issues:
mod - .gitignore Diff File
mod - wwwroot/inc/database.php Diff File

master c3fe0898

2017-07-20 14:19:26

infrastation

Details Diff
colorHex2Rgb(): round floats to integers

Firefox accepted "rgb(127.5,127.5,255)" but Chrome [properly] didn't:

"The format of an RGB value in the functional notation is 'rgb(' followed
by a comma-separated list of three numerical values (either three integer
values or three percentage values) followed by ')'." -- CSS spec

Add some tests.
Attach Issues:
mod - wwwroot/inc/interface-lib.php Diff File
mod - tests/PureFunctionTest.php Diff File

master 4fd21be1

2017-07-20 13:29:34

infrastation

Details Diff
renderTagRowForViewer(): fixup some markup

In the tag tree viewer apply tag class to the tag name only rather than
to the whole TR, this is consistent with the tag filter portlet and does
not conflict with the viewer sometimes using the TR to signal additional
information (a warning or not assignable) about the tag.
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master 213ea1eb

2017-07-20 13:00:53

Maik Ehinger


Committer: infrastation Details Diff
colorHex2Rgb(): try a different RGB math

This should fix the color SELECT in some browsers.
Attach Issues:
mod - wwwroot/inc/interface-lib.php Diff File

master 5580b167

2017-07-20 11:18:45

infrastation

Details Diff
rename syncObjectPorts() to replaceObjectPorts()

This way the code in doSwitchSNMPmining() and doPDUSNMPmining() is much
easier to understand.
Attach Issues:
mod - wwwroot/inc/snmp.php Diff File
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/functions.php Diff File

master 36e3ad37

2017-07-20 10:32:21

infrastation

Details Diff
makeWhereSQL(): do not specify a default value

All arguments to this function are mandatory, also amend the tests.
Attach Issues:
mod - wwwroot/inc/database.php Diff File
mod - tests/PureFunctionTest.php Diff File

master 21c8b04f

2017-07-20 10:11:11

infrastation

Details Diff
refine NATv4 address selector popup

* getAllIPv4Allocations(): fetch one more column and fixup SQL formatting
* renderPopupIPv4Selector(): improve formatting like in commit f4d00fa
* sortTokenize(): don't call count() more often than required, use
isUnsignedInteger() and numCompare()
Attach Issues:
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/popup.php Diff File
mod - wwwroot/inc/functions.php Diff File

master 0f13d32c

2017-07-20 09:04:47

infrastation

Details Diff
spell l2addressForDatabase() consistently
Attach Issues:
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/functions.php Diff File

master 1c094559

2017-07-19 15:47:21

infrastation

Details Diff
make some code style fixups

* rebuildTagChainForEntity()
* setEntityColors()
* buildTagCheckboxRows()
* coloredObject()
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File
mod - wwwroot/inc/interface.php Diff File
mod - wwwroot/inc/interface-lib.php Diff File
mod - wwwroot/inc/solutions.php Diff File
mod - wwwroot/inc/database.php Diff File

master 6f3dfa80

2017-07-19 15:03:29

infrastation

Details Diff
isInteger(): add helper code around is_numeric()

The previous commit passed the tests on PHP 7 but not on PHP 5 due to the
difference in is_numeric(). Make it work the same on both PHP versions
and add some more tests.
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - tests/PureFunctionTest.php Diff File

master f7686eb8

2017-07-19 12:52:47

infrastation

Details Diff
refine the SQL column type for tag colour

MySQL char(6) can contain any string including a hex notation of a 24-bit
RGB colour. With this storage type the PHP code should check if the value
is valid every time it reads the column, and if the value is invalid
there is no good way to deal with it as the invalid value could have been
stored a long time ago and it could be caused by a bug in a
non-interactive script so there is nowhere to put the blame.

Based on the prior experience it is better to eliminate this place for an
error earliest possible, do this by switching to an unsigned 24-bit
integer type in the MySQL table, this way any non-NULL value stored in
the column is always valid and any attempt to store an invalid value will
fail at one or another level immediately so there is a feedback loop now.

* get_pseudo_file(): update CREATE TABLE
* upgrade.php: modify ALTER TABLE
* getTagList(): amend SELECT to convert to hex at server side
* commitUpdateTag(): amend column conversion
* $opspec_list: refine declarations for tagtree-edit-createTag
* isHTMLColor(): reduce to a small unary function and add tests
* HTMLColorForDatabase(): new converter function with tests
* HTMLColorFromDatabase(): idem
* assertHTMLColorArg(): simplify and merge into genericAssertion()
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File
mod - wwwroot/inc/install.php Diff File
mod - wwwroot/inc/upgrade.php Diff File
mod - wwwroot/inc/functions.php Diff File
mod - tests/PureFunctionTest.php Diff File
mod - wwwroot/inc/database.php Diff File

master a7c7af63

2017-07-19 11:13:15

infrastation

Details Diff
amend ChangeLog for the previous commit
Attach Issues:
mod - ChangeLog Diff File

master d8f3e96f

2017-07-18 12:15:34

infrastation

Details Diff
loadConfigDefaults(): don't do foreach() by ref.
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
 First  Prev  1 2 3 ... 15 16 17 18 19 20 21 ... 40 ... 60 ... 80 ... 100 ... 120 ... 140 ... 160 ... 180 ... 200 ... 218 219 220  Next  Last