Changesets: RackTables

master 88441715

2017-05-23 12:27:04

infrastation

Details Diff
setUserConfigVar(): use REPLACE INTO consistently
Attach Issues:
mod - wwwroot/inc/database.php Diff File

master 70c0cb08

2017-05-23 12:09:34

infrastation

Details Diff
refine renderPortsForObject()

Convert a repeated code block to a function, fixup a TD alignment,
simplify portlet rendering, do not show the multiport form if
permissions would not allow to submit.
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 07d22cec

2017-05-19 13:03:45

infrastation

Details Diff
simplify a few functions

* lastInsertID(): use PDOStatement::fetchColumn()
* getIPv4Stats(): idem
* getIPv6Stats(): idem
* getRackspaceStats(): idem
* sortPortList(): use array_fetch()
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/database.php Diff File

master e984d86c

2017-05-19 12:04:35

infrastation

Details Diff
set Port.label to NULL instead of an empty string

This is how it was originally intended (also update the sample dataset).

* commitAddPortReal(): use nullIfEmptyStr()
* commitUpdatePortReal(): idem
* upgrade.php: queue an UPDATE for 0.21.0
Attach Issues:
mod - wwwroot/inc/upgrade.php Diff File
mod - scripts/init-sample-racks.sql Diff File
mod - wwwroot/inc/database.php Diff File

master 2d07e596

2017-05-19 11:43:55

infrastation

Details Diff
renderSNMPPortFinder(): remove excess LABELs
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master ef82cfcf

2017-05-19 10:48:53

infrastation

Details Diff
tests: add a missing newline at EOF
Attach Issues:
mod - tests/EmptySQLWhereTest.php Diff File

master 83ea38a9

2017-05-19 10:45:38

infrastation

Details Diff
suppress some more unnecessary default values

Amend respective test to fail the right way.

* usePreparedDeleteBlade()
* usePreparedUpdateBlade()
Attach Issues:
mod - tests/EmptySQLWhereTest.php Diff File
mod - wwwroot/inc/database.php Diff File

master 710bb27b

2017-05-18 12:56:42

infrastation

Details Diff
copy complete 0.20.x releases only into master
Attach Issues:
mod - wwwroot/inc/upgrade.php Diff File

master 1acbe865

2017-05-18 12:26:40

infrastation

Details Diff
display MySQL warnings in debug mode

This optional means of debugging can provide a feedback loop when the
strict SQL mode is not enabled.

* collectMySQLWarnings(): new function to buffer the warnings
* usePreparedInsertBlade(): amend to call the above
* usePreparedDeleteBlade(): idem
* usePreparedUpdateBlade(): idem
* showMySQLWarnings(): new function to display the buffer
* index.php: call the above in the "redirect" case
Attach Issues:
mod - wwwroot/inc/interface-lib.php Diff File
mod - wwwroot/inc/database.php Diff File
mod - ChangeLog Diff File
mod - wwwroot/index.php Diff File

master 832453d0

2017-05-18 10:05:11

infrastation

Details Diff
upgrade.php: add a section for 0.21.0
Attach Issues:
mod - wwwroot/inc/upgrade.php Diff File

master e8d843f4

2017-05-16 18:16:57

infrastation

Details Diff
refine the use of $debug_mode

* authenticated_via_saml(): remove an unused global
* EntityNotFoundException::dispatch(): check isset() first
Attach Issues:
mod - wwwroot/inc/auth.php Diff File
mod - wwwroot/inc/exceptions.php Diff File

master 0d328046

2017-05-16 13:22:40

infrastation

Details Diff
fixup the has_problems table column for rack rows

Commits 873c6a5 and 725d2f6 took care of the subsequent updates, this
change addresses any old rows that may have been written by the old
version.
Attach Issues:
mod - wwwroot/inc/upgrade.php Diff File

master 175ee5f5

2017-05-16 12:59:49

infrastation

Details Diff
upgrade.php: add a section for 0.20.14
Attach Issues:
mod - wwwroot/inc/upgrade.php Diff File

master 5ba31f4f

2017-05-16 12:44:35

infrastation

Details Diff
Travis CI: stick with PHPUnit 5 to fix PHP 7 build

Travis CI support has troubleshooted the issue, this change implements
one of the solutions they suggest. Commit 42f767b describes the previous
workaround for the same problem.
Attach Issues:
mod - .travis.yml Diff File

master 566bef84

2017-05-15 17:46:54

infrastation

Details Diff
split CREATE USER and GRANT (Mantis#1727)
Attach Issues:
mod - tests/travis_setup_mysql.sh Diff File
mod - tests/README.md Diff File
mod - wwwroot/inc/install.php Diff File

master ab7c0d8b

2017-05-12 13:57:56

infrastation

Details Diff
0.20.13: cut the release
Attach Issues:
add - tests/data/0.20.13.sql Diff File
mod - ChangeLog Diff File
mod - wwwroot/inc/config.php Diff File

master 11b1059e

2017-05-10 18:28:31

infrastation

Details Diff
add two more integrity tests for object ports

Follow up with the recent commits in renderDataIntegrityReport().
Attach Issues:
mod - wwwroot/inc/interface-reports.php Diff File

master c25f01c5

2017-05-09 09:28:16

infrastation

Details Diff
checkPortRole(): don't put "else" after "return"
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master 90d512eb

2017-05-08 16:38:48

infrastation

Details Diff
improve the L2 address constraint check

Add a new function assertUniqueL2Addresses(), which accepts a list of
L2 addresses and tests them all with at most one SQL query. It also
incorporates the existing convention of an empty L2 address being OK,
such that the calling functions now have less checks to make.

Make alreadyUsedL2Address() just a wrapper for the above. Switch
commitAddPort(), commitUpdatePort() and syncObjectPorts() to the new
function. Since syncObjectPorts() does not throw IRAE anymore, add
missing try/catch blocks to doSwitchSNMPmining() and doPDUSNMPmining().
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/snmp.php Diff File
mod - wwwroot/inc/database.php Diff File

master 6f949688

2017-05-08 12:52:13

infrastation

Details Diff
refine more exception classes in port management

InvalidArgException means that a parameter has an invalid value in
general, whereas InvalidRequestArgException specifically means that
in addition to that the parameter value is the user input from a more
or less interactive session.

In the latter case the error message should be displayed back to the user
or, if the code does not expect the IRAE class for whatever reason, the
exception should land in the [supposedly present] more general IAE catch
block.

With that in mind fix a long-standing anomaly by making commitAddPort()
and commitUpdatePort() throw an IAE object instead of IRAE. Make changes
to addPortForObject(), editPortForObject(), autoPopulateUCS() and
renameObjectPorts() such that those functions expect an IAE and can
reasonably handle it. Amend test declarations as necessary.

While at it, move code around in syncObjectPorts() to make sure all
exceptions cause the tables lock released soonest possible.
Attach Issues:
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/ophandlers.php Diff File
mod - tests/PortTriggerTest.php Diff File

master 74b81bfc

2017-05-08 10:31:11

infrastation

Details Diff
refine exception class in addMultiPorts()

The default case stands for a bug in software as the invalid input does
not come from the user. Dispatch it as such.
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File

master decba4dd

2017-05-08 10:28:46

infrastation

Details Diff
fixup formatting nits after commit 2e912e8

* getSelect(): escape the single option case properly
* renderPortsForObject(): add a missing space char
Attach Issues:
mod - wwwroot/inc/interface-lib.php Diff File
mod - wwwroot/inc/interface.php Diff File

master 2e27dbbf

2017-05-07 17:53:56

infrastation

Details Diff
autoPopulateUCS(): just use switch()
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File

master 2e912e83

2017-05-07 16:32:51

infrastation

Details Diff
remove obsolete port declaration formats

* renderPortsForObject()
* addMultiPorts()
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File
mod - wwwroot/inc/interface.php Diff File

master 83f61752

2017-05-07 16:26:21

infrastation

Details Diff
generatePortsForCatModule(): unused, remove
Attach Issues:
mod - wwwroot/inc/snmp.php Diff File
 First  Prev  1 2 3 ... 17 18 19 20 21 22 23 ... 40 ... 60 ... 80 ... 100 ... 120 ... 140 ... 160 ... 180 ... 200 ... 217 218 219  Next  Last