Changesets: RackTables

master 3a243872

2017-06-27 13:28:20

infrastation

Details Diff
renderObject(): make rackspace portlet conditional

Original idea by Lucas Aimaretto.
Attach Issues:
mod - ChangeLog Diff File
mod - wwwroot/inc/interface.php Diff File

master e9446e3b

2017-06-23 16:05:09

infrastation

Details Diff
don't call getConfigVar('EXT_IPV4_VIEW') too often

Specifically, not inside foreach.

* renderObject()
* renderIPForObject()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 5ff78aff

2017-06-23 12:59:21

infrastation

Details Diff
refine editing of attributes

It used to be possible to map "date" attributes to racks, rows and
locations, but the properties editor would not know how to handle
those attributes in particular and would not make permission checks
correctly in general.

This change addresses those issues by replacing four similar code
blocks with one new function that can handle all types of attributes
for all types of objects and makes necessary permission checks.

* renderEditAttributeTRs(): a new universal function
* renderEditRowForm(): use the new function instead of custom local code
* renderEditObjectForm(): idem
* renderEditRackForm(): idem
* renderEditLocationForm(): idem
* updateObjectAttributes(): update request argument checks to match
what the current implementation puts into the form
Attach Issues:
mod - wwwroot/inc/interface.php Diff File
mod - wwwroot/inc/ophandlers.php Diff File
mod - ChangeLog Diff File

master 5b908204

2017-06-22 13:55:14

infrastation

Details Diff
refine displaying of attributes

formatAttributeValue() was initially purposed for objects and when it
yielded a hyperlink it would hard-code "page=depot" into it. When the
function was later reused for racks, rows and locations, this logic
didn't deliver working URLs.

Add necessary checks such that this feature only tries to work when it
can work, add a date format mouse hint, add minimal reporting of RackCode
parsing errors and move some code around for clarity.

Modify the functions below as required:
* renderRow()
* renderRackInfoPortlet()
* renderObject()
* renderSearchResults()
* renderLocationPage()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File
mod - ChangeLog Diff File

master b4fb59fa

2017-06-20 12:42:26

infrastation

Details Diff
printPDOException(): refine some text

In this context the class name is always PDOException.
Attach Issues:
mod - wwwroot/inc/exceptions.php Diff File

master dfc8176e

2017-06-16 18:43:05

infrastation

Details Diff
make the object properties form more user-friendly

updateObjectAttributes() used to feed each new attribute value to MySQL
connection and let it raise an exception for an invalid input. The
exception would be dispatched as a hard error with the MySQL error
codes and a stack trace page.

Improve this by making calls to genericAssertion() as required and
converting any resulting IRAE exceptions to a human-readable form.

Add helper methods getValue() and getReason() to InvalidArgException.
Attach Issues:
mod - wwwroot/inc/exceptions.php Diff File
mod - wwwroot/inc/ophandlers.php Diff File

master 8bdd76e7

2017-06-16 17:12:25

infrastation

Details Diff
decrease direct use of $_REQUEST and $sic, pt. 20

* updateObjectAttributes()
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File

master 0a7ffbe4

2017-06-16 16:45:04

infrastation

Details Diff
spell a public class method as public

Keep it consistent with the other declarations in the file.
Attach Issues:
mod - wwwroot/inc/exceptions.php Diff File

master cf720255

2017-06-16 15:41:44

infrastation

Details Diff
improve the previous change

Do the same for IPv6 and make a ChangeLog entry.

* getIPv4PrefixSearchResult()
* getIPv6PrefixSearchResult()
Attach Issues:
mod - wwwroot/inc/database.php Diff File
mod - ChangeLog Diff File

master ed4484b8

2017-06-16 15:17:46

fstuck


Committer: infrastation Details Diff
cover comments too in IPv4 search (Mantis#1773)

* getIPv4PrefixSearchResult()
Attach Issues:
mod - wwwroot/inc/database.php Diff File

master 20e18046

2017-06-16 10:20:00

infrastation

Details Diff
dictionary: add another OS release (Mantis#1769)
Attach Issues:
mod - wwwroot/inc/dictionary.php Diff File

master e28c58ad

2017-06-15 13:36:00

andriyanov


Committer: infrastation Details Diff
scanIPSpace: optimize SQL for fetching last log

Use the same WHERE filter in subquery. Changed functions:
- scanIPv4Space
- scanIPv6Space
Attach Issues:
mod - wwwroot/inc/database.php Diff File

master 336e7e60

2017-06-06 16:53:18

infrastation

Details Diff
fixup transparency in a few images
Attach Issues:
mod - wwwroot/pix/racks.png Diff File
mod - wwwroot/pix/server.png Diff File
mod - wwwroot/pix/addressspacev6.png Diff File
mod - wwwroot/pix/report.png Diff File

master 6eb70f01

2017-06-06 11:27:54

infrastation

Details Diff
refine delivery of rack thumb images

A read-only RackTables instance would display an error image instead of
the thumbnail image for any rack that has invalidated thumbnail cache.
This change makes it deliver the thumbnail even if the attempted cache
update failed because of insufficient database permissions.

* RTDBTableAccessDenied: a new exception class
* convertPDOException(): add a respective case block for the error code
* dispatchMiniRackThumbRequest(): use the above for its REPLACE and
update the comment
Attach Issues:
mod - ChangeLog Diff File
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/solutions.php Diff File
mod - wwwroot/inc/exceptions.php Diff File

master 837ad4ae

2017-06-02 16:20:51

infrastation

Details Diff
printTagsPickerUl(): don't modify foreach argument
Attach Issues:
mod - wwwroot/inc/interface-lib.php Diff File

master 6cf6a09f

2017-06-02 13:43:28

infrastation

Details Diff
replace a couple default values with explicit ones

There is no reason to specify a default value for $input_name in
printTagsPickerInput() and printTagsPickerUl() so long as
printTagsPicker() is the only function that calls those functions.
Attach Issues:
mod - wwwroot/inc/interface-lib.php Diff File

master 35d895be

2017-05-30 13:26:50

infrastation

Details Diff
fix a typo in README.md
Attach Issues:
mod - README.md Diff File

master 5ceaa179

2017-05-26 19:07:34

infrastation

Details Diff
improve CodeMirror integration

Reimplement the RackCode language mode in rackcode.js using simpler
JavaScript code and define a standalone "rackcode" theme in rackcode.css
instead of overriding the default theme. In renderRackCodeEditor() pass
more properties to CodeMirror constructor and make minor HTML fixups.
In renderRackCodeViewer() rewrite the code to use CodeMirror in read-only
mode and to scroll to requested line on request. Amend the URL format in
refRCLineno() respectively.
Attach Issues:
mod - wwwroot/js/codemirror/rackcode.js Diff File
mod - ChangeLog Diff File
mod - wwwroot/inc/code.php Diff File
mod - wwwroot/css/codemirror/rackcode.css Diff File
mod - wwwroot/inc/interface-config.php Diff File

master 03102e0e

2017-05-26 17:28:12

infrastation

Details Diff
remove remaining stray props of CodePress

This completes the changes done in commit cf5da67.

* renderRackCodeEditor()
* renderTextEditor()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File
mod - wwwroot/inc/interface-config.php Diff File

master d765a3df

2017-05-25 18:16:42

infrastation

Details Diff
upgrade CodeMirror from 3.24 to 5.26.0

For simpler maintenance the RackTables-specific CSS modifications now
reside in css/codemirror/rackcode.css. Do not include the CSS, HTML,
JavaScript, PHP and SQL CodeMirror tokenizers anymore as they had not
proved to be useful.
Attach Issues:
rm - wwwroot/js/codemirror/sql.js Diff File
rm - wwwroot/js/codemirror/css.js Diff File
add - wwwroot/css/codemirror/rackcode.css Diff File
mod - wwwroot/inc/interface-config.php Diff File
rm - wwwroot/js/codemirror/php.js Diff File
rm - wwwroot/js/codemirror/codemirror.css Diff File
rm - wwwroot/js/codemirror/htmlmixed.js Diff File
mod - wwwroot/js/codemirror/codemirror.js Diff File
mod - wwwroot/js/codemirror/rackcode.js Diff File
add - wwwroot/css/codemirror/codemirror.css Diff File
rm - wwwroot/js/codemirror/javascript.js Diff File

master a6374660

2017-05-25 09:54:12

infrastation

Details Diff
revert to pristine CodeMirror-3.24
Attach Issues:
mod - wwwroot/js/codemirror/codemirror.css Diff File

master f4d00faf

2017-05-24 18:54:31

infrastation

Details Diff
better display objects that have no common name

Address a long-standing glitch: when a port on the currently displayed
object was (or was suggested to be) linked to a port of an object that
had no name, the displayed remote object name would be an empty string.
This change makes the interface display a standard substitute instead,
which among other things makes the remote object hyperlink clickable.

* fetchPortList(): add remote object type ID to the result columns
* renderObjectPortRow(): make use of formatObjectDisplayedName()
* renderPortsForObject(): idem
* findSparePorts(): all of the above
Attach Issues:
mod - wwwroot/inc/interface.php Diff File
mod - ChangeLog Diff File
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/popup.php Diff File

master ecd0c5a0

2017-05-24 12:08:35

infrastation

Details Diff
recognize context in CodeMirror RackCode lexer
Attach Issues:
mod - wwwroot/js/codemirror/rackcode.js Diff File

master bb216c1c

2017-05-23 14:15:23

shazaum


Committer: infrastation Details Diff
Edge-Core had the product discontinued
Attach Issues:
mod - wwwroot/inc/dictionary.php Diff File

master 88441715

2017-05-23 12:27:04

infrastation

Details Diff
setUserConfigVar(): use REPLACE INTO consistently
Attach Issues:
mod - wwwroot/inc/database.php Diff File
 First  Prev  1 2 3 ... 17 18 19 20 21 22 23 ... 40 ... 60 ... 80 ... 100 ... 120 ... 140 ... 160 ... 180 ... 200 ... 218 219 220  Next  Last