Changesets: RackTables

master c4928e38

2016-01-23 11:57:43

infrastation

Details Diff
buildOpspecColumns(): use array_fetch()
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File

master 3c3487c8

2016-01-23 11:42:39

infrastation

Details Diff
support generic translator functions in opspec

* buildOpspecColumns(): add handling for the new optional 'translator'
property but still allow the old 'if_empty' edge case as a fallback
* switch existing opspec declarations to the new syntax:
* object-editrspvs-updLB
* tagtree-edit-createTag
* vlandomain-vlanlist-add
* vlandomain-vlanlist-upd
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File

master 03738f2d

2016-01-23 11:10:05

infrastation

Details Diff
rename nullEmptyStr() to nullIfEmptyStr()

Retain the old name for backward compatibility. Update functions:

* commitAddObject()
* commitRenameObject()
* commitUpdateObject()
* commitAddPort()
* commitUpdatePort()
* commitUpdatePortComment()
* linkPorts()
* commitUpdatePortLink()
* addVService()
* updateVS()
* updateIPInVS()
* updatePortInVS()
* updateTripletConfig()
* updateTripletConfig()
* addRStoRSPool()
* addLBtoRSPool()
* commitUpdateRS()
* commitUpdateVS()
* commitUpdateRS()
* commitUpdateVS()
* commitCreateRSPool()
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/slb.php Diff File
mod - wwwroot/inc/ophandlers.php Diff File

master babbe17c

2016-01-23 10:52:41

infrastation

Details Diff
factor 0 -> NULL coalescing out

* nullIfZero(): new function
* commitUpdateTag(): update to use
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/database.php Diff File

master e9bebc29

2016-01-23 10:48:18

infrastation

Details Diff
factor FALSE -> NULL coalescing out

This is similar to nullEmptyStr() but uses a slightly different naming
pattern for readability.

* nullIfFalse(): new function, a wrapper for ternary expression
* fetchIPv4AddressNetworkRow(): update to use
* fetchIPv6AddressNetworkRow(): ditto
* loadScript(): ditto
* findFileByName(): ditto
* getUserIDByUsername(): ditto
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/database.php Diff File

master b72aeb98

2016-01-22 16:43:13

infrastation

Details Diff
amend Makefile (follow-up to commit 2797f2c)
Attach Issues:
mod - Makefile Diff File

master ae405349

2016-01-22 15:31:22

infrastation

Details Diff
renderTagRowForEditor(): don't import $taglist

The only purpose of it was to find out the parent tag name, which is
much simpler to receive from the calling function (and isn't defined
for a root node).
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master 7e081f01

2016-01-22 13:39:27

infrastation

Details Diff
factor addParentNodeOptionsJS() out
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master e0b414d2

2016-01-22 12:40:39

infrastation

Details Diff
renderConfigMainpage(): address a FIXME
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master b46bd2c6

2016-01-21 18:31:24

infrastation

Details Diff
generalize the graph cycles resolver

The tag forest editor tab used to have a separate form for resolving
graph cycle issues in the TagTree database table. This change reworks
the form into a standalone generic tab that makes it possible for the
user to fix similar data structures given these are declared in the
function.

* getOrphanedTags(): generalize and rename to getInvalidNodes()
* renderTagTreeEditor(): handle the forest structure only
* renderGraphCycleResolver(): new function with the tabhandler
* renderDataIntegrityReport(): amend
* triggerGraphCycleResolver(): new function
Attach Issues:
mod - wwwroot/inc/triggers.php Diff File
mod - wwwroot/inc/interface-config.php Diff File
mod - wwwroot/inc/navigation.php Diff File
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/interface-reports.php Diff File

master a05a92de

2016-01-21 17:00:29

infrastation

Details Diff
reduceSubarraysToColumn(): amend the comment
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master 824886b2

2016-01-20 22:22:40

infrastation

Details Diff
authorize upd-rack-sort-order AJAX request

* renderRackSortForm(): include row_id in the request
* updateRackSortOrderAJAX(): set and check security context
Attach Issues:
mod - wwwroot/inc/interface.php Diff File
mod - wwwroot/inc/ajax-interface.php Diff File

master 80ee8a14

2016-01-20 14:53:43

infrastation

Details Diff
getLocationSelectAJAX(): do authorization
Attach Issues:
mod - wwwroot/inc/ajax-interface.php Diff File

master ac5ecf31

2016-01-20 12:32:36

infrastation

Details Diff
renderTagTreeEditor(): make a few minor fixes
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master f66a7547

2016-01-20 12:18:52

infrastation

Details Diff
detail parent node filtering further

Recognize the two different use cases: one where parent node filtering
is done for an existing node in a forest of rooted trees and another
when it is done for a potential new node or a node that is currently
based on a circular reference.

* getParentNodeOptionsNew(): new function
* getParentNodeOptions(): rename to getParentNodeOptionsExisting()
* getParentNodeOptionsAJAX(): amend the AJAX request format and handling
respectively
* renderTagTreeEditor(): make use of those changes and extend the
"circular references" block to suggest the parent node options that
link the nodes back into the valid structure
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File
mod - wwwroot/inc/ajax-interface.php Diff File
mod - wwwroot/inc/functions.php Diff File

master 4eafa7cb

2016-01-19 13:49:19

andriyanov

Details Diff
optimize addTraceToNodes function

Do not traverse entire node list multiple times.

This change reduces the function runtime in my environment from 6ms to
1ms.
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master 3bb17fdc

2016-01-19 13:35:38

infrastation

Details Diff
generalize parent node options AJAX

* navigation: replace "get-tag-select" with "get-parent-node-options"
* renderTagRowForEditor(): rename AJAX request parameters
* renderTagTreeEditor(): idem
* getTagSelectAJAX(): replace with the two new generic functions below
* getParentNodeOptions(): new function to produce the list of options
* getParentNodeOptionsAJAX(): new function to interface with AJAX
clients (with the existing "node_type=tag" case now using a security
context)
Attach Issues:
mod - wwwroot/inc/navigation.php Diff File
mod - wwwroot/inc/interface-config.php Diff File
mod - wwwroot/inc/ajax-interface.php Diff File
mod - wwwroot/inc/functions.php Diff File

master 58ba94bc

2016-01-19 10:35:03

infrastation

Details Diff
add a unit test for getSelectOptions()
Attach Issues:
add - tests/getSelectOptionsTest.php Diff File

master 97e7ed8b

2016-01-19 10:10:25

infrastation

Details Diff
tests: put assertEquals() arguments right

The method is assertEquals ($expected, $actual), the other way around
it would generate a misleading message on mismatch.
Attach Issues:
mod - tests/LinkTriggerTest.php Diff File
mod - tests/UpgradeTest.php Diff File
mod - tests/StringInsertHrefsTest.php Diff File

master 7fa85099

2016-01-19 09:49:36

infrastation

Details Diff
renderTagTreeEditor(): remove an unused global
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master d1f4958f

2016-01-19 09:27:04

infrastation

Details Diff
dictionary: OS entries for small routers and APs
Attach Issues:
mod - wwwroot/inc/dictionary.php Diff File

master 0efdbdbc

2016-01-18 19:30:53

infrastation

Details Diff
factor getAttributeOptions() out

Some of the code that used to be in renderEditAttrMapForm() doesn't
quite belong there and can be reused elsewhere. Switch to getSelect()
while at it.
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master dea303ac

2016-01-18 16:16:05

infrastation

Details Diff
factor SELECT OPTIONs generation out

* getSelectOptions(): new function with the code from getSelect()
* getSelect(): use getSelectOptions()
* getTagSelectAJAX(): use getSelectOptions()
* getVSTOptions(): simplify as it doesn't have to call stringForOption()
anymore
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/ajax-interface.php Diff File
mod - wwwroot/inc/interface-lib.php Diff File

master 549c279b

2016-01-18 16:04:52

infrastation

Details Diff
renderEditAttrMapForm(): use getSelect()
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master a1f2407c

2016-01-18 10:33:05

infrastation

Details Diff
improve use of nullEmptyStr()

Amend nullEmptyStr() to test against an empty string as that's what it
is interested in. Replace a number of equivalent constructs with a call
to nullEmptyStr() in the following functions:

* commitAddObject()
* commitRenameObject()
* commitUpdateObject()
* commitUpdatePort()
* commitUpdatePortComment()
* linkPorts()
* commitUpdatePortLink()
* addVService()
* addRStoRSPool()
* addLBtoRSPool()
* commitUpdateRS()
* commitUpdateVS()
* commitCreateRSPool()
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/ophandlers.php Diff File
mod - wwwroot/inc/slb.php Diff File
 First  Prev  1 2 3 ... 20 ... 37 38 39 40 41 42 43 ... 60 ... 80 ... 100 ... 120 ... 140 ... 160 ... 180 ... 200 ... 217 218 219  Next  Last