Changesets: RackTables

master 0e975b95

2016-02-03 11:38:50

andriyanov

Details Diff
optimize apply8021QOrder

This change improves performance significantly for switches having lot
of ports (~1000)
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master b7d6c410

2016-02-02 15:49:58

infrastation

Details Diff
tests: cover numSign() and numCompare()
Attach Issues:
mod - tests/PureFunctionTest.php Diff File

master 6d82daf5

2016-02-02 15:44:49

infrastation

Details Diff
tests: fix a typo in a comment
Attach Issues:
mod - tests/PureFunctionTest.php Diff File

master 480a109d

2016-02-02 12:43:19

infrastation

Details Diff
add a note as a follow-up to commit a04b65c
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master 99f9fa70

2016-02-02 11:57:16

infrastation

Details Diff
tests: cover formatVSIP()
Attach Issues:
mod - tests/PureFunctionTest.php Diff File

master a02c0c18

2016-02-02 11:25:11

infrastation

Details Diff
generalize pure function tests

Merge getSelectOptionsTest.php and NullIfTest.php into
PureFunctionTest.php, which now provides declarative means of testing of
6 kinds of pure functions (1-, 2- and 3-ary; PHP "equal" and "identical"
operators).

Leave the empty test suites commented out to suppress PHPUnit warnings.
Attach Issues:
add - tests/PureFunctionTest.php Diff File
rm - tests/NullIfTest.php Diff File
rm - tests/getSelectOptionsTest.php Diff File

master d0b45183

2016-02-01 10:43:51

infrastation

Details Diff
factor file download button code out

* makeFileDownloadButton(): new function
* renderFileSummary(): update
* renderFileDownloader(): update
* renderCell(): update
Attach Issues:
mod - wwwroot/inc/interface.php Diff File
mod - wwwroot/inc/interface-lib.php Diff File

master 2224b8a8

2016-01-31 20:59:23

infrastation

Details Diff
renderCellList(): use etypeByPageno()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 60d83c86

2016-01-29 12:07:10

infrastation

Details Diff
refresh renderVSTRulesEditor()

Move global declaration to the top, simplify some code, don't do OPTION
escaping, allow printOpFormIntro() generate a form parameter, use
array_fetch().
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 4a4f2614

2016-01-29 09:51:17

infrastation

Details Diff
getVlanRow(): spell NULL comparison uniformly

Though there is no difference between == and === in this particular
context, use === for consistency with other similar tests so the code
can be copied and pasted without unintended effects.
Attach Issues:
mod - wwwroot/inc/database.php Diff File

master 6cd500ea

2016-01-29 09:05:00

infrastation

Details Diff
remove old code in a comment
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master 70bc004f

2016-01-27 17:48:55

infrastation

Details Diff
address "No newline at end of file"

Vim and probably other editors are unhappy about a file not ending with
a newline, just add it now to keep future diffs cleaner.
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File
mod - wwwroot/inc/interface-reports.php Diff File
mod - wwwroot/inc/interface-cables.php Diff File

master 86c3a55e

2016-01-27 17:44:12

andriyanov

Details Diff
queryTerminal: 'terminal echo-mode line' for vrp55

Huawei devices that apply to the 'vrp55' breed echoes all the input
commands back to terminal in single-byte chunks. This causes too
many TCP segments to be sent by switch if it gets a plenty of verbose
commands.

'terminal echo-mode line' command disables this behavior. It does not
exist in vrp85 software series.
Attach Issues:
mod - ChangeLog Diff File
mod - wwwroot/inc/remote.php Diff File

master 78ba6f56

2016-01-27 12:37:43

infrastation

Details Diff
make a few minor corrections to interface.php

This change stands for commits 9da8ee2 and 1c834d5 without the
unnecessary changes.

* renderNewRackForm(): remove unused argument
* renderIPNetworkProperties(): use etypeByPageno(), remove redundant
argument to getOpLink()
* renderFileDownloader(): use makeHref()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master d10401bf

2016-01-27 10:59:29

infrastation

Details Diff
Revert "use getBypassValue() in interface.php"

This reverts commit 9da8ee2.
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 20a87be1

2016-01-27 10:45:42

infrastation

Details Diff
Revert "renderIPNetworkProperties(): use etypeByPageno()"

This reverts commit 1c834d5.
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 1c834d51

2016-01-26 12:54:35

infrastation

Details Diff
renderIPNetworkProperties(): use etypeByPageno()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 9da8ee26

2016-01-26 12:51:57

infrastation

Details Diff
use getBypassValue() in interface.php

Update the functions below to use getBypassValue() instead of expecting
their own argument because they belong to pages with a bypass parameter:

* renderRow()
* renderEditRowForm()
* renderRackSortForm()
* renderNewRackForm()
* renderEditRackForm()
* renderObject()
* renderPortsForObject()
* renderIPForObject()
* renderPortsInfo()
* renderRackSpaceForObject()
* renderIPNetwork()
* renderIPNetworkProperties()
* renderNATv4ForObject()
* renderLocationPage()
* renderEditLocationForm()
* renderRackPage()
* renderSNMPPortFinder()
* renderLivePTR()
* renderAutoPortsForm()
* renderTagRollerForRow()
* renderFile()
* renderFileDownloader()
* renderFileProperties()
* renderTextEditor()
* renderObject8021QPorts()
* renderObject8021QSync()
* renderVST()
* renderVSTRulesEditor()
* renderDiscoveredNeighbors()
* renderObjectCactiGraphs()
* renderObjectMuninGraphs()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 7db42425

2016-01-26 12:17:02

infrastation

Details Diff
refine file upload error handling

addFileWithoutLink() would create a 1-byte RackTables file on a failure
to open the upload temporary file. Update addFileWithoutLink() and
addFileToEntity() to check both error conditions and produce respective
error messages.
Attach Issues:
mod - ChangeLog Diff File
mod - wwwroot/inc/ophandlers.php Diff File

master 06429eb4

2016-01-26 10:12:25

infrastation

Details Diff
renderRackSpaceForObject(): remove duplicate code
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master f7a9c2fe

2016-01-25 13:28:58

andriyanov

Details Diff
Fix string crop in SELECT options

The issue with commit dea303 is that string cropping should occur only
once. Now it takes place in getSelect(), so additional calls to
niftyString() prior to getSelect must be removed.
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/interface.php Diff File

master 044027f1

2016-01-25 13:27:37

andriyanov

Details Diff
proper use of niftyString

formatPatchCableHeapAsPlainText: pass FALSE as third parameter as long
as this function returns plain text.
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master f7f6f05a

2016-01-24 13:12:43

infrastation

Details Diff
tests: cover the recently introduced functions
Attach Issues:
add - tests/NullIfTest.php Diff File

master 325107ce

2016-01-24 11:44:44

infrastation

Details Diff
put commit 03738f2 right
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master c4928e38

2016-01-23 11:57:43

infrastation

Details Diff
buildOpspecColumns(): use array_fetch()
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File
 First  Prev  1 2 3 ... 20 ... 37 38 39 40 41 42 43 ... 60 ... 80 ... 100 ... 120 ... 140 ... 160 ... 180 ... 200 ... 218 219 220  Next  Last