Changesets: RackTables

master 4a4f2614

2016-01-29 09:51:17

infrastation

Details Diff
getVlanRow(): spell NULL comparison uniformly

Though there is no difference between == and === in this particular
context, use === for consistency with other similar tests so the code
can be copied and pasted without unintended effects.
Attach Issues:
mod - wwwroot/inc/database.php Diff File

master 6cd500ea

2016-01-29 09:05:00

infrastation

Details Diff
remove old code in a comment
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master 70bc004f

2016-01-27 17:48:55

infrastation

Details Diff
address "No newline at end of file"

Vim and probably other editors are unhappy about a file not ending with
a newline, just add it now to keep future diffs cleaner.
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File
mod - wwwroot/inc/interface-reports.php Diff File
mod - wwwroot/inc/interface-cables.php Diff File

master 86c3a55e

2016-01-27 17:44:12

andriyanov

Details Diff
queryTerminal: 'terminal echo-mode line' for vrp55

Huawei devices that apply to the 'vrp55' breed echoes all the input
commands back to terminal in single-byte chunks. This causes too
many TCP segments to be sent by switch if it gets a plenty of verbose
commands.

'terminal echo-mode line' command disables this behavior. It does not
exist in vrp85 software series.
Attach Issues:
mod - ChangeLog Diff File
mod - wwwroot/inc/remote.php Diff File

master 78ba6f56

2016-01-27 12:37:43

infrastation

Details Diff
make a few minor corrections to interface.php

This change stands for commits 9da8ee2 and 1c834d5 without the
unnecessary changes.

* renderNewRackForm(): remove unused argument
* renderIPNetworkProperties(): use etypeByPageno(), remove redundant
argument to getOpLink()
* renderFileDownloader(): use makeHref()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master d10401bf

2016-01-27 10:59:29

infrastation

Details Diff
Revert "use getBypassValue() in interface.php"

This reverts commit 9da8ee2.
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 20a87be1

2016-01-27 10:45:42

infrastation

Details Diff
Revert "renderIPNetworkProperties(): use etypeByPageno()"

This reverts commit 1c834d5.
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 1c834d51

2016-01-26 12:54:35

infrastation

Details Diff
renderIPNetworkProperties(): use etypeByPageno()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 9da8ee26

2016-01-26 12:51:57

infrastation

Details Diff
use getBypassValue() in interface.php

Update the functions below to use getBypassValue() instead of expecting
their own argument because they belong to pages with a bypass parameter:

* renderRow()
* renderEditRowForm()
* renderRackSortForm()
* renderNewRackForm()
* renderEditRackForm()
* renderObject()
* renderPortsForObject()
* renderIPForObject()
* renderPortsInfo()
* renderRackSpaceForObject()
* renderIPNetwork()
* renderIPNetworkProperties()
* renderNATv4ForObject()
* renderLocationPage()
* renderEditLocationForm()
* renderRackPage()
* renderSNMPPortFinder()
* renderLivePTR()
* renderAutoPortsForm()
* renderTagRollerForRow()
* renderFile()
* renderFileDownloader()
* renderFileProperties()
* renderTextEditor()
* renderObject8021QPorts()
* renderObject8021QSync()
* renderVST()
* renderVSTRulesEditor()
* renderDiscoveredNeighbors()
* renderObjectCactiGraphs()
* renderObjectMuninGraphs()
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master 7db42425

2016-01-26 12:17:02

infrastation

Details Diff
refine file upload error handling

addFileWithoutLink() would create a 1-byte RackTables file on a failure
to open the upload temporary file. Update addFileWithoutLink() and
addFileToEntity() to check both error conditions and produce respective
error messages.
Attach Issues:
mod - ChangeLog Diff File
mod - wwwroot/inc/ophandlers.php Diff File

master 06429eb4

2016-01-26 10:12:25

infrastation

Details Diff
renderRackSpaceForObject(): remove duplicate code
Attach Issues:
mod - wwwroot/inc/interface.php Diff File

master f7a9c2fe

2016-01-25 13:28:58

andriyanov

Details Diff
Fix string crop in SELECT options

The issue with commit dea303 is that string cropping should occur only
once. Now it takes place in getSelect(), so additional calls to
niftyString() prior to getSelect must be removed.
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/interface.php Diff File

master 044027f1

2016-01-25 13:27:37

andriyanov

Details Diff
proper use of niftyString

formatPatchCableHeapAsPlainText: pass FALSE as third parameter as long
as this function returns plain text.
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master f7f6f05a

2016-01-24 13:12:43

infrastation

Details Diff
tests: cover the recently introduced functions
Attach Issues:
add - tests/NullIfTest.php Diff File

master 325107ce

2016-01-24 11:44:44

infrastation

Details Diff
put commit 03738f2 right
Attach Issues:
mod - wwwroot/inc/functions.php Diff File

master c4928e38

2016-01-23 11:57:43

infrastation

Details Diff
buildOpspecColumns(): use array_fetch()
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File

master 3c3487c8

2016-01-23 11:42:39

infrastation

Details Diff
support generic translator functions in opspec

* buildOpspecColumns(): add handling for the new optional 'translator'
property but still allow the old 'if_empty' edge case as a fallback
* switch existing opspec declarations to the new syntax:
* object-editrspvs-updLB
* tagtree-edit-createTag
* vlandomain-vlanlist-add
* vlandomain-vlanlist-upd
Attach Issues:
mod - wwwroot/inc/ophandlers.php Diff File

master 03738f2d

2016-01-23 11:10:05

infrastation

Details Diff
rename nullEmptyStr() to nullIfEmptyStr()

Retain the old name for backward compatibility. Update functions:

* commitAddObject()
* commitRenameObject()
* commitUpdateObject()
* commitAddPort()
* commitUpdatePort()
* commitUpdatePortComment()
* linkPorts()
* commitUpdatePortLink()
* addVService()
* updateVS()
* updateIPInVS()
* updatePortInVS()
* updateTripletConfig()
* updateTripletConfig()
* addRStoRSPool()
* addLBtoRSPool()
* commitUpdateRS()
* commitUpdateVS()
* commitUpdateRS()
* commitUpdateVS()
* commitCreateRSPool()
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/database.php Diff File
mod - wwwroot/inc/slb.php Diff File
mod - wwwroot/inc/ophandlers.php Diff File

master babbe17c

2016-01-23 10:52:41

infrastation

Details Diff
factor 0 -> NULL coalescing out

* nullIfZero(): new function
* commitUpdateTag(): update to use
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/database.php Diff File

master e9bebc29

2016-01-23 10:48:18

infrastation

Details Diff
factor FALSE -> NULL coalescing out

This is similar to nullEmptyStr() but uses a slightly different naming
pattern for readability.

* nullIfFalse(): new function, a wrapper for ternary expression
* fetchIPv4AddressNetworkRow(): update to use
* fetchIPv6AddressNetworkRow(): ditto
* loadScript(): ditto
* findFileByName(): ditto
* getUserIDByUsername(): ditto
Attach Issues:
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/database.php Diff File

master b72aeb98

2016-01-22 16:43:13

infrastation

Details Diff
amend Makefile (follow-up to commit 2797f2c)
Attach Issues:
mod - Makefile Diff File

master ae405349

2016-01-22 15:31:22

infrastation

Details Diff
renderTagRowForEditor(): don't import $taglist

The only purpose of it was to find out the parent tag name, which is
much simpler to receive from the calling function (and isn't defined
for a root node).
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master 7e081f01

2016-01-22 13:39:27

infrastation

Details Diff
factor addParentNodeOptionsJS() out
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master e0b414d2

2016-01-22 12:40:39

infrastation

Details Diff
renderConfigMainpage(): address a FIXME
Attach Issues:
mod - wwwroot/inc/interface-config.php Diff File

master b46bd2c6

2016-01-21 18:31:24

infrastation

Details Diff
generalize the graph cycles resolver

The tag forest editor tab used to have a separate form for resolving
graph cycle issues in the TagTree database table. This change reworks
the form into a standalone generic tab that makes it possible for the
user to fix similar data structures given these are declared in the
function.

* getOrphanedTags(): generalize and rename to getInvalidNodes()
* renderTagTreeEditor(): handle the forest structure only
* renderGraphCycleResolver(): new function with the tabhandler
* renderDataIntegrityReport(): amend
* triggerGraphCycleResolver(): new function
Attach Issues:
mod - wwwroot/inc/triggers.php Diff File
mod - wwwroot/inc/interface-config.php Diff File
mod - wwwroot/inc/navigation.php Diff File
mod - wwwroot/inc/functions.php Diff File
mod - wwwroot/inc/interface-reports.php Diff File
 First  Prev  1 2 3 ... 20 ... 37 38 39 40 41 42 43 ... 60 ... 80 ... 100 ... 120 ... 140 ... 160 ... 180 ... 200 ... 218 219 220  Next  Last