View Issue Details

IDProjectCategoryView StatusLast Update
1337RackTablesdefaultpublic2014-09-26 17:42
Reportertmalkowski Assigned To 
PrioritynoneSeveritytrivialReproducibilityN/A
Status closedResolutionsuspended 
Product Version0.20.7 
Summary1337: Add comment field to ipv4space page
DescriptionOur managers asked for a comment field to be added to the ipv4space page, so they could quickly locate a particular subnet at a glance. I patched our instance, but thought it might be useful for others as well. The patch is attached to this issue.
TagsNo tags attached.

Activities

tmalkowski

tmalkowski

2014-09-10 20:23

reporter  

interface.php.patch (1,100 bytes)   
--- inc/interface.php.orig	2014-09-10 12:43:57.792201797 -0500
+++ inc/interface.php	2014-09-10 13:02:07.864193826 -0500
@@ -2514,6 +2514,10 @@
 
 			if ($display_routers)
 				printRoutersTD (findRouters ($item['own_addrlist']), getConfigVar ('IPV4_TREE_RTR_AS_CELL'));
+
+			// comment
+			echo "<td class=\"tdleft\">" . niftyString ($item['comment'], 0) . "</td>";
+
 			echo "</tr>";
 			if ($item['symbol'] == 'node-expanded' or $item['symbol'] == 'node-expanded-static')
 				$self ($item['kids'], $baseurl, $target, $level + 1);
@@ -2530,6 +2534,7 @@
 			echo "</td>";
 			if ($display_routers)
 				echo "<td></td>";
+			echo "<td class=\"tdleft\">" . niftyString ($item['comment'], 0) . "</td>";
 			echo "</tr>";
 		}
 	}
@@ -2590,6 +2595,7 @@
 			echo "<tr><th>prefix</th><th>name/tags</th><th>capacity</th>";
 			if (getConfigVar ('IPV4_TREE_RTR_AS_CELL') != 'none')
 				echo "<th>routed by</th>";
+			echo "<th>comment</th>";
 			echo "</tr>\n";
 			$baseurl = makeHref(array('page'=>$pageno, 'tab'=>$tabno)) . $cellfilter['urlextra'];
 			renderIPSpaceRecords ($tree, $baseurl, $eid);
interface.php.patch (1,100 bytes)   
tmalkowski

tmalkowski

2014-09-16 18:43

reporter   ~0002507

Last edited: 2014-09-16 18:44

Submitted pull request via github: https://github.com/RackTables/racktables/pull/80

infrastation

infrastation

2014-09-26 17:42

administrator   ~0002513

Closing this bug as as the pull request has superseded it.

Issue History

Date Modified Username Field Change
2014-09-10 20:23 tmalkowski New Issue
2014-09-10 20:23 tmalkowski File Added: interface.php.patch
2014-09-16 18:43 tmalkowski Note Added: 0002507
2014-09-16 18:44 tmalkowski Note Edited: 0002507
2014-09-26 17:42 infrastation Note Added: 0002513
2014-09-26 17:42 infrastation Status new => closed
2014-09-26 17:42 infrastation Resolution open => suspended