View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
1337 | RackTables | default | public | 2014-09-10 20:23 | 2014-09-26 17:42 |
Reporter | tmalkowski | Assigned To | |||
Priority | none | Severity | trivial | Reproducibility | N/A |
Status | closed | Resolution | suspended | ||
Product Version | 0.20.7 | ||||
Summary | 1337: Add comment field to ipv4space page | ||||
Description | Our managers asked for a comment field to be added to the ipv4space page, so they could quickly locate a particular subnet at a glance. I patched our instance, but thought it might be useful for others as well. The patch is attached to this issue. | ||||
Tags | No tags attached. | ||||
interface.php.patch (1,100 bytes)
--- inc/interface.php.orig 2014-09-10 12:43:57.792201797 -0500 +++ inc/interface.php 2014-09-10 13:02:07.864193826 -0500 @@ -2514,6 +2514,10 @@ if ($display_routers) printRoutersTD (findRouters ($item['own_addrlist']), getConfigVar ('IPV4_TREE_RTR_AS_CELL')); + + // comment + echo "<td class=\"tdleft\">" . niftyString ($item['comment'], 0) . "</td>"; + echo "</tr>"; if ($item['symbol'] == 'node-expanded' or $item['symbol'] == 'node-expanded-static') $self ($item['kids'], $baseurl, $target, $level + 1); @@ -2530,6 +2534,7 @@ echo "</td>"; if ($display_routers) echo "<td></td>"; + echo "<td class=\"tdleft\">" . niftyString ($item['comment'], 0) . "</td>"; echo "</tr>"; } } @@ -2590,6 +2595,7 @@ echo "<tr><th>prefix</th><th>name/tags</th><th>capacity</th>"; if (getConfigVar ('IPV4_TREE_RTR_AS_CELL') != 'none') echo "<th>routed by</th>"; + echo "<th>comment</th>"; echo "</tr>\n"; $baseurl = makeHref(array('page'=>$pageno, 'tab'=>$tabno)) . $cellfilter['urlextra']; renderIPSpaceRecords ($tree, $baseurl, $eid); |
|
Submitted pull request via github: https://github.com/RackTables/racktables/pull/80 |
|
Closing this bug as as the pull request has superseded it. | |
Date Modified | Username | Field | Change |
---|---|---|---|
2014-09-10 20:23 | tmalkowski | New Issue | |
2014-09-10 20:23 | tmalkowski | File Added: interface.php.patch | |
2014-09-16 18:43 | tmalkowski | Note Added: 0002507 | |
2014-09-16 18:44 | tmalkowski | Note Edited: 0002507 | |
2014-09-26 17:42 | infrastation | Note Added: 0002513 | |
2014-09-26 17:42 | infrastation | Status | new => closed |
2014-09-26 17:42 | infrastation | Resolution | open => suspended |