View Issue Details

IDProjectCategoryView StatusLast Update
419RackTablesdefaultpublic2012-01-01 01:55
Reporterinfrastation Assigned Toadoom42  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version0.19.10 
Target Version0.19.11Fixed in Version0.19.11 
Summary419: VRRP review
Descriptionby Tyler J. Wagner:

Attached is a patch to allow multiple routers on one IP. Valid from
0.18.x to current (0.19.2). IE, when one IP has multiple "Router"-type
assignments, it does not appear with red background colour. Good for
those of us with VRRP-speaking devices sharing common IPs.
TagsNo tags attached.

Activities

2011-04-10 19:26

 

multiple-router-ip-allocations.diff (935 bytes)   
--- functions.php_orig	2011-03-24 12:44:33.000000000 +0000
+++ functions.php	2011-03-28 15:04:43.000000000 +0000
@@ -1728,9 +1728,10 @@
 		);
 		foreach ($addrlist[$ip_bin]['allocs'] as $a)
 			$refc[$a['type']]++;
-		$nvirtloopback = ($refc['shared'] + $refc['virtual'] > 0) ? 1 : 0; // modulus of virtual + shared
+		// 2010-10-08 tyler - routers may have multiple allocations on one IP
+		$nvirtloopback = ($refc['shared'] + $refc['virtual'] + $refc['router'] > 0) ? 1 : 0; // modulus of virtual + shared + router
 		$nreserved = ($addrlist[$ip_bin]['reserved'] == 'yes') ? 1 : 0; // only one reservation is possible ever
-		$nrealms = $nreserved + $nvirtloopback + $refc['regular'] + $refc['router']; // latter two are connected and router allocations
+		$nrealms = $nreserved + $nvirtloopback + $refc['regular']; // last is connected allocation
 		
 		if ($nrealms == 1)
 			$addrlist[$ip_bin]['class'] = 'trbusy';
adoom42

adoom42

2012-01-01 01:55

administrator   ~0000498

Thanks for the patch.

Issue History

Date Modified Username Field Change
2011-04-10 19:26 infrastation New Issue
2011-04-10 19:26 infrastation File Added: multiple-router-ip-allocations.diff
2011-04-10 19:39 infrastation Assigned To => infrastation
2011-04-10 19:39 infrastation Status new => acknowledged
2012-01-01 01:55 adoom42 Note Added: 0000498
2012-01-01 01:55 adoom42 Assigned To infrastation => adoom42
2012-01-01 01:55 adoom42 Reproducibility have not tried => always
2012-01-01 01:55 adoom42 Status acknowledged => closed
2012-01-01 01:55 adoom42 Resolution open => fixed
2012-01-01 01:55 adoom42 Product Version => 0.19.10
2012-01-01 01:55 adoom42 Fixed in Version => 0.19.11
2012-01-01 01:55 adoom42 Target Version => 0.19.11