View Issue Details

IDProjectCategoryView StatusLast Update
819RackTablesdefaultpublic2013-04-26 06:59
Reportersgnl05 Assigned To 
PrioritylowSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version0.20.3 
Target Version0.20.5Fixed in Version0.20.5 
Summary819: Feature request: Rackcode filter for RDP-managed objects
DescriptionThe function "Rackcode filter for SSH-managed objects" found in the Configuration/User Interface creates a link to "ssh://address" out of the FQDN address on the view page of an object.

Can we please get an equivalent function for RDP, making a link to "rdp://address" ?

TagsNo tags attached.

Activities

fspijkerman

fspijkerman

2013-04-25 21:30

reporter   ~0001333

Ive attached a patch that implements this.

If you have an existing install make sure you apply this sql statement in your database:
INSERT INTO `Config` (varname, varvalue, vartype, emptyok, is_hidden, is_userdefined, description) VALUES ('RDP_OBJS_LISTSRC','false','string','yes','no','yes','Rackcode filter for RDP-managed objects')
fspijkerman

fspijkerman

2013-04-25 21:31

reporter  

rdp-racktables-filter.diff (3,135 bytes)   
diff --git a/wwwroot/inc/install.php b/wwwroot/inc/install.php
index dbf0278..d22e590 100644
--- a/wwwroot/inc/install.php
+++ b/wwwroot/inc/install.php
@@ -1629,6 +1629,7 @@ INSERT INTO `Config` (varname, varvalue, vartype, emptyok, is_hidden, is_userdef
 ('PORT_EXCLUSION_LISTSRC','{\$typeid_3} or {\$typeid_10} or {\$typeid_11} or {\$typeid_1505} or {\$typeid_1506}','string','yes','no','no','List source: objects without ports'),
 ('FILTER_RACKLIST_BY_TAGS','yes','string','yes','no','yes','Rackspace: show only racks matching the current object\'s tags'),
 ('SSH_OBJS_LISTSRC','false','string','yes','no','yes','Rackcode filter for SSH-managed objects'),
+('RDP_OBJS_LISTSRC','false','string','yes','no','yes','Rackcode filter for RDP-managed objects'),
 ('TELNET_OBJS_LISTSRC','false','string','yes','no','yes','Rackcode filter for telnet-managed objects'),
 ('SYNC_802Q_LISTSRC','','string','yes','no','no','List of VLAN switches sync is enabled on'),
 ('QUICK_LINK_PAGES','depot,ipv4space,rackspace','string','yes','no','yes','List of pages to dislay in quick links'),
diff --git a/wwwroot/inc/interface.php b/wwwroot/inc/interface.php
index 40ca19f..1ce2c42 100644
--- a/wwwroot/inc/interface.php
+++ b/wwwroot/inc/interface.php
@@ -8128,8 +8128,9 @@ function formatAttributeValue ($record)
 		if ($record['id'] == 3) // FQDN attribute
 		{
 			$protos_to_try = array (
-				'ssh' => 'SSH_OBJS_LISTSRC',
+				'ssh'    => 'SSH_OBJS_LISTSRC',
 				'telnet' => 'TELNET_OBJS_LISTSRC',
+				'rdp'    => 'RDP_OBJS_LISTSRC',
 			);
 			foreach ($protos_to_try as $proto => $cfgvar)
 				if (considerConfiguredConstraint (NULL, $cfgvar))
diff --git a/wwwroot/inc/ophandlers.php b/wwwroot/inc/ophandlers.php
index 7412fb5..84c47ee 100644
--- a/wwwroot/inc/ophandlers.php
+++ b/wwwroot/inc/ophandlers.php
@@ -1465,6 +1465,7 @@ function resetUIConfig()
 	setConfigVar ('PORT_EXCLUSION_LISTSRC', '{$typeid_3} or {$typeid_10} or {$typeid_11} or {$typeid_1505} or {$typeid_1506}');
 	setConfigVar ('FILTER_RACKLIST_BY_TAGS', 'yes');
 	setConfigVar ('SSH_OBJS_LISTSRC', 'false');
+	setConfigVar ('RDP_OBJS_LISTSRC', 'false');
 	setConfigVar ('TELNET_OBJS_LISTSRC', 'false');
 	setConfigVar ('SYNC_802Q_LISTSRC', '');
 	setConfigVar ('QUICK_LINK_PAGES', 'depot,ipv4space,rackspace');
diff --git a/wwwroot/inc/upgrade.php b/wwwroot/inc/upgrade.php
index 86088d6..070b0e7 100644
--- a/wwwroot/inc/upgrade.php
+++ b/wwwroot/inc/upgrade.php
@@ -1650,6 +1650,9 @@ CREATE TABLE `MuninGraph` (
 			$query[] = "INSERT INTO `Config` (varname, varvalue, vartype, emptyok, is_hidden, is_userdefined, description) VALUES ('NEAREST_RACKS_CHECKBOX', 'yes', 'string', 'yes', 'no', 'yes', 'Enable nearest racks in port list filter by default')";
 			$query[] = "UPDATE Config SET varvalue = '0.20.4' WHERE varname = 'DB_VERSION'";
 			break;
+		case '0.20.5':
+			$query[] = "INSERT INTO `Config` (varname, varvalue, vartype, emptyok, is_hidden, is_userdefined, description) VALUES ('RDP_OBJS_LISTSRC','false','string','yes','no','yes','Rackcode filter for RDP-managed objects')";
+			break;
 		case 'dictionary':
 			$query = reloadDictionary();
 			break;
rdp-racktables-filter.diff (3,135 bytes)   
infrastation

infrastation

2013-04-26 06:59

administrator   ~0001335

The fix by Frank Spijkerman will be available in the next stable release (0.20.5). Thank you!

Issue History

Date Modified Username Field Change
2013-04-05 12:24 sgnl05 New Issue
2013-04-25 21:30 fspijkerman Note Added: 0001333
2013-04-25 21:31 fspijkerman File Added: rdp-racktables-filter.diff
2013-04-25 21:34 fspijkerman Status new => feedback
2013-04-26 06:59 infrastation Note Added: 0001335
2013-04-26 06:59 infrastation Status feedback => closed
2013-04-26 06:59 infrastation Resolution open => fixed
2013-04-26 06:59 infrastation Fixed in Version => 0.20.5
2013-04-26 06:59 infrastation Target Version => 0.20.5