View Issue Details

IDProjectCategoryView StatusLast Update
2071RackTablesdefaultpublic2023-03-21 22:37
Reporternetniv Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status acknowledgedResolutionopen 
Product Version0.22.0 
Summary2071: Helpdesk Banner usage not consistent
DescriptionThe Helpdesk Banner which can be added to the bottom of exceptions is not included in all instances
Steps To ReproduceA generic exception will not display the help desk banner information
TagsNo tags attached.

Activities

netniv

netniv

2022-10-31 19:32

reporter   ~0004445

diff --git a/wwwroot/inc/exceptions.php b/wwwroot/inc/exceptions.php
index adf545aa..9dfaadc7 100644
--- a/wwwroot/inc/exceptions.php
+++ b/wwwroot/inc/exceptions.php
@@ -266,7 +266,8 @@ class RTPermissionDenied extends RackTablesError
                        $target_given_tags,
                        $auto_tags,
                        $expl_tags,
- $impl_tags;
+ $impl_tags,
+ $helpdesk_banner;
                header ('Content-Type: text/html; charset=UTF-8');
                echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">' . "\n";
                echo '<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">' . "\n";
@@ -290,6 +291,8 @@ class RTPermissionDenied extends RackTablesError
                echo "<tr><th width='50%' class=tdright>Requested tab:</th><td class=tdleft>${tabno}</td></tr>\n";
                echo "<tr><td colspan=2 align=center>Click <a href='index.php?logout'>here</a> to logout.</td></tr>\n";
                echo "</table>\n";
+ if (isset ($helpdesk_banner))
+ echo '<hr>' . $helpdesk_banner;
                echo '</body></html>';
        }
 }
@@ -400,6 +403,8 @@ function stringTrace ($trace)

 function printPDOException ($e)
 {
+ global $helpdesk_banner;
+
        header ('HTTP/1.1 500 Internal Server Error');
        header ('Content-Type: text/html; charset=UTF-8');
        echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">' . "\n";
@@ -423,11 +428,15 @@ function printPDOException ($e)
        dumpArray ($_POST);
        echo '<h3>COOKIE</h3>';
        dumpArray ($_COOKIE);
+ if (isset ($helpdesk_banner))
+ echo '<hr>' . $helpdesk_banner;
        echo '</body></html>';
 }

 function printGenericException ($e)
 {
+ global $helpdesk_banner;
+
        header('HTTP/1.1 500 Internal Server Error');
        header ('Content-Type: text/html; charset=UTF-8');
        echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">' . "\n";
@@ -447,6 +456,8 @@ function printGenericException ($e)
        dumpArray ($_POST);
        echo '<h3>COOKIE</h3>';
        dumpArray ($_COOKIE);
+ if (isset ($helpdesk_banner))
+ echo '<hr>' . $helpdesk_banner;
        echo '</body></html>';
 }

Issue History

Date Modified Username Field Change
2022-10-31 19:21 netniv New Issue
2022-10-31 19:32 netniv Note Added: 0004445
2023-03-21 22:37 infrastation Status new => acknowledged